yiguolei commented on code in PR #22388:
URL: https://github.com/apache/doris/pull/22388#discussion_r1278664955


##########
be/src/service/internal_service.cpp:
##########
@@ -373,6 +377,10 @@ void 
PInternalServiceImpl::_tablet_writer_add_block(google::protobuf::RpcControl
         int64_t execution_time_ns = 0;
         {
             SCOPED_RAW_TIMER(&execution_time_ns);
+            TUniqueId tid;
+            tid.__set_hi(request->id().hi());
+            tid.__set_lo(request->id().lo());
+            SCOPED_ATTACH_TASK(tid);

Review Comment:
   这样做可能不对,因为导入的内存是手动统计的,如果在一个be 上有insert into select,如果这里自动统计出错,那么可能导致select 
端被挂掉。



##########
be/src/service/internal_service.cpp:
##########
@@ -373,6 +377,10 @@ void 
PInternalServiceImpl::_tablet_writer_add_block(google::protobuf::RpcControl
         int64_t execution_time_ns = 0;
         {
             SCOPED_RAW_TIMER(&execution_time_ns);
+            TUniqueId tid;
+            tid.__set_hi(request->id().hi());
+            tid.__set_lo(request->id().lo());
+            SCOPED_ATTACH_TASK(tid);

Review Comment:
   这样做可能不对,因为导入的内存是手动统计的,如果在一个be 上有insert into select,如果这里自动统计出错,那么可能导致select 
端被挂掉。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to