adonis0147 commented on code in PR #22109:
URL: https://github.com/apache/doris/pull/22109#discussion_r1278704311
##########
build.sh:
##########
@@ -703,4 +703,8 @@ if [[ -n "${DORIS_POST_BUILD_HOOK}" ]]; then
eval "${DORIS_POST_BUILD_HOOK}"
fi
+if [[ -f "${CMAKE_BUILD_DIR}/compile_commands.json" ]]; then
+ ln -s "${CMAKE_BUILD_DIR}/compile_commands.json"
"${DORIS_HOME}/compile_commands.json"
+fi
+
Review Comment:
I don't think the path `${DORIS_HOME}/compile_commands.json` is appropriate.
We have two build scripts, one is for `src` and another one is for `test`.
These build scripts will generate different `compile_commands.json`. Linking
the `compile_commands.json` to the root of the project would affects these
build targets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
