This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 4d3e56e2e7 [fix][regression-test] change lazy open regression test
name (#22404)
4d3e56e2e7 is described below
commit 4d3e56e2e714629dc83318c074434ee6b027f1ce
Author: HHoflittlefish777 <[email protected]>
AuthorDate: Tue Aug 1 20:26:10 2023 +0800
[fix][regression-test] change lazy open regression test name (#22404)
---
be/src/runtime/tablets_channel.cpp | 7 -------
be/src/runtime/tablets_channel.h | 3 ---
be/src/vec/sink/vtablet_sink.h | 2 --
....groovy => test_materialized_view_load_open.groovy} | 18 +++++++++---------
4 files changed, 9 insertions(+), 21 deletions(-)
diff --git a/be/src/runtime/tablets_channel.cpp
b/be/src/runtime/tablets_channel.cpp
index 7f45b404b7..af0b6ffd9b 100644
--- a/be/src/runtime/tablets_channel.cpp
+++ b/be/src/runtime/tablets_channel.cpp
@@ -114,13 +114,6 @@ Status TabletsChannel::open(const
PTabletWriterOpenRequest& request) {
return Status::OK();
}
-void TabletsChannel::_build_partition_tablets_relation(const
PTabletWriterOpenRequest& request) {
- for (auto& tablet : request.tablets()) {
-
_partition_tablets_map[tablet.partition_id()].emplace_back(tablet.tablet_id());
- _tablet_partition_map[tablet.tablet_id()] = tablet.partition_id();
- }
-}
-
Status TabletsChannel::close(
LoadChannel* parent, int sender_id, int64_t backend_id, bool* finished,
const google::protobuf::RepeatedField<int64_t>& partition_ids,
diff --git a/be/src/runtime/tablets_channel.h b/be/src/runtime/tablets_channel.h
index 17bdcf5ec8..d7384c502e 100644
--- a/be/src/runtime/tablets_channel.h
+++ b/be/src/runtime/tablets_channel.h
@@ -126,7 +126,6 @@ private:
google::protobuf::RepeatedPtrField<PTabletInfo>*
tablet_vec,
google::protobuf::RepeatedPtrField<PTabletError>*
tablet_errors,
PSlaveTabletNodes slave_tablet_nodes, const bool
write_single_replica);
- void _build_partition_tablets_relation(const PTabletWriterOpenRequest&
request);
void _add_broken_tablet(int64_t tablet_id);
void _add_error_tablet(google::protobuf::RepeatedPtrField<PTabletError>*
tablet_errors,
@@ -165,8 +164,6 @@ private:
// status to return when operate on an already closed/cancelled channel
// currently it's OK.
Status _close_status;
- std::map<int64, std::vector<int64>> _partition_tablets_map;
- std::map<int64, int64> _tablet_partition_map;
// tablet_id -> TabletChannel
// when you erase, you should call deregister_writer method in
MemTableMemoryLimiter;
diff --git a/be/src/vec/sink/vtablet_sink.h b/be/src/vec/sink/vtablet_sink.h
index 1e5d6ea2d7..be50285fd8 100644
--- a/be/src/vec/sink/vtablet_sink.h
+++ b/be/src/vec/sink/vtablet_sink.h
@@ -598,8 +598,6 @@ private:
bool _try_close = false;
bool _prepare = false;
- std::atomic<bool> _open_partition_done {false};
-
// User can change this config at runtime, avoid it being modified during
query or loading process.
bool _transfer_large_data_by_brpc = false;
diff --git
a/regression-test/suites/rollup_p0/test_materialized_view_lazy_open.groovy
b/regression-test/suites/rollup_p0/test_materialized_view_load_open.groovy
similarity index 93%
rename from
regression-test/suites/rollup_p0/test_materialized_view_lazy_open.groovy
rename to
regression-test/suites/rollup_p0/test_materialized_view_load_open.groovy
index 6891484128..040d0118ac 100644
--- a/regression-test/suites/rollup_p0/test_materialized_view_lazy_open.groovy
+++ b/regression-test/suites/rollup_p0/test_materialized_view_load_open.groovy
@@ -15,15 +15,15 @@
// specific language governing permissions and limitations
// under the License.
-suite("test_materialized_view_lazy_open", "rollup") {
+suite("test_materialized_view_load_open", "rollup") {
// because nereids cannot support rollup correctly forbid it temporary
sql """set enable_nereids_planner=false"""
- def tbName1 = "test_materialized_view_lazy_open"
- def tbName2 = "test_materialized_view_lazy_open_dynamic_partition"
- def tbName3 = "test_materialized_view_lazy_open_schema_change"
- def tbName4 =
"test_materialized_view_lazy_open_dynamic_partition_schema_change"
+ def tbName1 = "test_materialized_view_load_open"
+ def tbName2 = "test_materialized_view_load_open_dynamic_partition"
+ def tbName3 = "test_materialized_view_load_open_schema_change"
+ def tbName4 =
"test_materialized_view_load_open_dynamic_partition_schema_change"
def getJobState = { tableName ->
def jobStateResult = sql """ SHOW ALTER TABLE MATERIALIZED VIEW WHERE
TableName='${tableName}' ORDER BY CreateTime DESC LIMIT 1; """
@@ -131,7 +131,7 @@ suite("test_materialized_view_lazy_open", "rollup") {
);
"""
- sql "CREATE materialized VIEW test_lazy_open AS SELECT k1 FROM ${tbName1}
GROUP BY k1;"
+ sql "CREATE materialized VIEW test_load_open AS SELECT k1 FROM ${tbName1}
GROUP BY k1;"
int max_try_secs = 60
while (max_try_secs--) {
String res = getJobState(tbName1)
@@ -148,7 +148,7 @@ suite("test_materialized_view_lazy_open", "rollup") {
}
}
- sql "CREATE materialized VIEW test_lazy_open_dynamic_partition AS SELECT
k1 FROM ${tbName2} GROUP BY k1;"
+ sql "CREATE materialized VIEW test_load_open_dynamic_partition AS SELECT
k1 FROM ${tbName2} GROUP BY k1;"
max_try_secs = 60
while (max_try_secs--) {
String res = getJobState(tbName2)
@@ -165,7 +165,7 @@ suite("test_materialized_view_lazy_open", "rollup") {
}
}
- sql "CREATE materialized VIEW test_lazy_open_schema_change AS SELECT k1
FROM ${tbName3} GROUP BY k1;"
+ sql "CREATE materialized VIEW test_load_open_schema_change AS SELECT k1
FROM ${tbName3} GROUP BY k1;"
max_try_secs = 60
while (max_try_secs--) {
String res = getJobState(tbName3)
@@ -182,7 +182,7 @@ suite("test_materialized_view_lazy_open", "rollup") {
}
}
- sql "CREATE materialized VIEW
test_lazy_open_dynamic_partition_schema_change AS SELECT k1 FROM ${tbName4}
GROUP BY k1;"
+ sql "CREATE materialized VIEW
test_load_open_dynamic_partition_schema_change AS SELECT k1 FROM ${tbName4}
GROUP BY k1;"
max_try_secs = 60
while (max_try_secs--) {
String res = getJobState(tbName4)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
