dataroaring commented on code in PR #22486:
URL: https://github.com/apache/doris/pull/22486#discussion_r1281357814
##########
be/src/olap/options.cpp:
##########
@@ -156,11 +166,17 @@ Status parse_conf_store_paths(const string& config_path,
std::vector<StorePath>*
} else {
LOG(WARNING) << "failed to parse store path " << item << ", res="
<< res;
}
+ if (path.storage_medium == TStorageMedium::HDD) {
+ ++hdd_cnt;
+ }
}
- if (paths->empty() || (path_vec.size() != paths->size() &&
!config::ignore_broken_disk)) {
+ if ((path_vec.size() != paths->size() && !config::ignore_broken_disk)) {
return Status::Error<INVALID_ARGUMENT>("fail to parse
storage_root_path config. value={}",
config_path);
}
+ if (hdd_cnt == 0) {
+ return Status::Error<INVALID_ARGUMENT>("should a least have one hdd
path");
+ }
Review Comment:
We should remove this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
