hubgeter commented on code in PR #22347:
URL: https://github.com/apache/doris/pull/22347#discussion_r1282966191
##########
be/src/exec/text_converter.cpp:
##########
@@ -62,12 +66,14 @@ void TextConverter::write_string_column(const
SlotDescriptor* slot_desc,
}
}
-bool TextConverter::write_vec_column(const SlotDescriptor* slot_desc,
- vectorized::IColumn* nullable_col_ptr,
const char* data,
- size_t len, bool copy_string, bool
need_escape, size_t rows) {
+bool TextConverter::write_date(const TypeDescriptor& type_desc,
+ vectorized::IColumn* nullable_col_ptr, const
char* data, size_t len,
+ bool copy_string, bool need_escape, size_t rows,
+ char array_delimiter) {
vectorized::IColumn* col_ptr = nullable_col_ptr;
// \N means it's NULL
- if (slot_desc->is_nullable()) {
+ std::string col_type_name = col_ptr->get_name();
+ if (col_type_name.substr(0, 8) == "Nullable") {
Review Comment:
Unable to obtain sub SlotDescriptor from SlotDescriptor . So use
`vectorized::IColumn * -> get_name` to determine whether the column type can
be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
