vagetablechicken commented on a change in pull request #4345:
URL: https://github.com/apache/incubator-doris/pull/4345#discussion_r469275507
##########
File path: be/src/runtime/mem_tracker.h
##########
@@ -588,14 +579,18 @@ class PoolMemTrackerRegistry {
/// with the process tracker as its parent. There is no explicit per-pool
byte_limit
/// set at any particular impalad, so newly created trackers will always
have a limit
/// of -1.
+ /// TODO(cmy): this method is not used for now. the memtracker returned from
here is
+ /// got from a shared_ptr in `pool_to_mem_trackers_`.
+ /// I don't know why it need to return a raw pointer.
+ /// If this method be further used, please notice that.
Review comment:
GetRequestPoolMemTracker is from
https://github.com/cloudera/Impala/blob/495397101e5807c701df71ea288f4815d69c2c8a/be/src/runtime/mem-tracker.h#L497
So we didn't make it shared last time, just Ieave it as it is. Maybe we
could return shared ptr, I think there should be no problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
