yiguolei commented on code in PR #22663:
URL: https://github.com/apache/doris/pull/22663#discussion_r1285838516
##########
be/src/olap/memtable_memory_limiter.cpp:
##########
@@ -44,7 +44,6 @@ MemTableMemoryLimiter::~MemTableMemoryLimiter() {
DEREGISTER_HOOK_METRIC(memtable_memory_limiter_mem_consumption);
for (auto writer : _writers) {
Review Comment:
this loop is useless, because the writers is cleared at line 51, and all
shared ptr will be cleared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
