morningman commented on code in PR #22665:
URL: https://github.com/apache/doris/pull/22665#discussion_r1286640373
##########
fe/fe-core/src/main/java/org/apache/doris/scheduler/disruptor/TaskHandler.java:
##########
@@ -119,12 +134,27 @@ public void onEventTask(TimerTaskEvent timerTaskEvent) {
jobTaskManager.addJobTask(jobTask);
}
+ public void onMemoryTask(TaskEvent taskEvent) {
Review Comment:
```suggestion
public void onTransientTaskSubmit(TaskEvent taskEvent) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/scheduler/disruptor/TaskType.java:
##########
@@ -0,0 +1,24 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.scheduler.disruptor;
+
+public enum TaskType {
+ TimerJobTask,
+
+ MemoryTask
Review Comment:
```suggestion
TransientTask
```
##########
fe/fe-core/src/main/java/org/apache/doris/scheduler/job/DorisTimerTask.java:
##########
@@ -27,8 +27,8 @@
/**
* This class represents a timer task that can be scheduled by a Netty timer.
- * When the timer task is triggered, it produces an event task using the
Disruptor.
- * The event task contains the ID of the event and the ID of the task itself.
+ * When the timer task is triggered, it produces a Job task using the
Disruptor.
+ * The Job task contains the ID of the Job and the ID of the task itself.
*/
@Getter
public class DorisTimerTask implements TimerTask {
Review Comment:
Better not name a class with `Doris` name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
