SunShine-1204 opened a new issue, #174: URL: https://github.com/apache/doris-flink-connector/issues/174
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.4.1 ### What's Wrong? In the DorisExecutionOptions constructor mode, some code is redundant. When building DorisSink, the dorisReadOptions property is nulled in the Build() method. The setDorisReadOptions(DorisReadOptions.builder().build()) configuration is not required when creating a connection, but it is not used in the build() method of creating DorisSource. Therefore, the above configuration must be added when creating a DorisSource connection. However, this configuration only provides DorisReadOptions objects without explicit property configuration. Therefore, it is not necessary to add this configuration when creating a connection. ### What You Expected? I advised to follow the DorisSink method when creating a DorisSource connection. In the Build() method of setDorisReadOptions, empty readOptions. If it is empty, assign a value to it. it does not need to add this configuration when creating a connection. ### How to Reproduce? // DorisSource DorisSource<List<?>> dorisSource = DorisSourceBuilder.<List<?>>builder() .setDorisOptions(builder.build()) .setDorisReadOptions(DorisReadOptions.builder().build()) // DorisSource不设置会报空指针 .setDeserializer(new SimpleListDeserializationSchema()) .build(); // DorisSink DorisSink.<RowData>builder() .setDorisReadOptions(DorisReadOptions.builder().build()) // .setDorisOptions(DorisOptions.builder() // DorisSink可不设置 .setFenodes("hadoop102:7030") .setTableIdentifier("test.table1") .setUsername("root") .setPassword("aaaaaa") .build()) ### Anything Else? no ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
