yiguolei commented on code in PR #22694:
URL: https://github.com/apache/doris/pull/22694#discussion_r1287360718
##########
be/src/vec/functions/function_cast.h:
##########
@@ -125,13 +126,13 @@ struct TimeCast {
// '300' -> 00:03:00 '20:23' -> 20:23:00 '20:23:24' -> 20:23:24
template <typename T>
static bool try_parse_time(char* s, size_t len, T& x, const
cctz::time_zone& local_time_zone,
- ZoneList& time_zone_cache) {
+ ZoneList& time_zone_cache, std::shared_mutex&
cache_lock) {
Review Comment:
加lock 更慢啊，为啥要改之前的thread local呢？
##########
be/src/vec/functions/function_cast.h:
##########
@@ -125,13 +126,13 @@ struct TimeCast {
// '300' -> 00:03:00 '20:23' -> 20:23:00 '20:23:24' -> 20:23:24
template <typename T>
static bool try_parse_time(char* s, size_t len, T& x, const
cctz::time_zone& local_time_zone,
- ZoneList& time_zone_cache) {
+ ZoneList& time_zone_cache, std::shared_mutex&
cache_lock) {
Review Comment:
加lock 更慢啊，为啥要改之前的thread local呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
