yiguolei commented on code in PR #22897:
URL: https://github.com/apache/doris/pull/22897#discussion_r1292269883
##########
be/src/vec/columns/column_string.h:
##########
@@ -140,15 +145,22 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
}
void insert(const Field& x) override {
- const String& s = vectorized::get<const String&>(x);
+ StringRef s;
Review Comment:
这里是不是直接写一个新的ColumnJSONB
##########
be/src/vec/columns/column_string.h:
##########
@@ -140,15 +145,22 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
}
void insert(const Field& x) override {
- const String& s = vectorized::get<const String&>(x);
+ StringRef s;
Review Comment:
这里是不是直接写一个新的ColumnJSONB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
