HappenLee commented on code in PR #22573:
URL: https://github.com/apache/doris/pull/22573#discussion_r1292812943
##########
be/src/vec/common/uint128.h:
##########
@@ -192,6 +192,19 @@ struct UInt256 {
return *this;
}
};
+
+#pragma pack(1)
+struct UInt136 {
+ UInt8 a;
+ UInt64 b;
+ UInt64 c;
+
+ bool operator==(const UInt136 rhs) const { return a == rhs.a && b == rhs.b
&& c == rhs.c; }
Review Comment:
better can use <=> in c++20 reduce the code if do not cause performance
problem
```
auto operator<=>(const UInt136& v) const = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
