yangzhg commented on a change in pull request #4425:
URL: https://github.com/apache/incubator-doris/pull/4425#discussion_r475303849
##########
File path: be/src/olap/row_cursor.h
##########
@@ -109,6 +109,14 @@ class RowCursor {
return column_schema(index)->index_size();
}
+ inline bool is_delete() const {
+ auto sign_idx = _schema->delete_sign_idx();
+ if (sign_idx < 0) {
+ return false;
+ }
+ return (*(char*) (cell(sign_idx).cell_ptr())) > 0;
Review comment:
better user reinterpret_cast
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
