xiaokang commented on code in PR #22687:
URL: https://github.com/apache/doris/pull/22687#discussion_r1296561021
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -563,7 +563,7 @@ public PlanFragment visitPhysicalOlapScan(PhysicalOlapScan
olapScan, PlanTransla
runtimeFilterTranslator ->
runtimeFilterTranslator.getTargetOnScanNode(olapScan.getRelationId())
.forEach(expr ->
runtimeFilterTranslator.translateRuntimeFilterTarget(
expr, olapScanNode, context)
- )
+ )
Review Comment:
too many unrelated format changes
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java:
##########
@@ -188,6 +214,55 @@ && couldConvertToMulti(agg))
);
}
+ private boolean containsMatchExpression(List<Expression> expressions) {
+ return expressions.stream().allMatch(expr -> expr instanceof Match);
+ }
+
+ private boolean enablePushDownCountOnIndex() {
+ ConnectContext connectContext = ConnectContext.get();
+ return connectContext == null ||
connectContext.getSessionVariable().isEnablePushDownCountOnIndex();
Review Comment:
connectContext != null &&
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2164,12 +2176,12 @@ Status
SegmentIterator::current_block_row_locations(std::vector<RowLocation>* bl
* call _check_column_pred_all_push_down will return false.
*/
bool SegmentIterator::_check_column_pred_all_push_down(const std::string&
column_name,
- bool in_compound) {
+ bool in_compound, bool
is_match) {
if (_remaining_conjunct_roots.empty()) {
return true;
}
- if (in_compound) {
+ if (in_compound || is_match) {
Review Comment:
it's already in #22836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
