morrySnow commented on code in PR #22963:
URL: https://github.com/apache/doris/pull/22963#discussion_r1300012913
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/scheduler/SimpleJobScheduler.java:
##########
@@ -28,10 +27,10 @@ public class SimpleJobScheduler implements JobScheduler {
public void executeJobPool(ScheduleContext scheduleContext) {
JobPool pool = scheduleContext.getJobPool();
while (!pool.isEmpty()) {
- CascadesContext context = (CascadesContext) scheduleContext;
- if (context.isTimeout()) {
- throw new RuntimeException("Nereids cost too much time ( > 5s
)");
- }
+ // CascadesContext context = (CascadesContext)
scheduleContext;
+ //// if (context.isTimeout()) {
+ //// throw new RuntimeException("Nereids cost too
much time ( > 5s )");
+ //// }
Review Comment:
what's this?
##########
fe/fe-core/src/main/java/org/apache/doris/persist/OperationType.java:
##########
@@ -323,6 +323,7 @@ public class OperationType {
public static final short OP_CREATE_SCHEDULER_TASK = 453;
public static final short OP_DELETE_SCHEDULER_TASK = 454;
+ public static final short OP_CREATE_TABLE_STATS = 455;
Review Comment:
```suggestion
public static final short OP_UPDATE_TABLE_STATS = 455;
```
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyzeProperties.java:
##########
@@ -32,6 +33,7 @@
public class AnalyzeProperties {
+ @SerializedName("analyzeProperties")
private final Map<String, String> properties;
Review Comment:
should put all static attr togather and all non-static attr togather
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
