morningman commented on a change in pull request #4470:
URL: https://github.com/apache/incubator-doris/pull/4470#discussion_r478522918
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLauncherMonitor.java
##########
@@ -103,7 +114,7 @@ public void run() {
try {
outReader = new BufferedReader(new
InputStreamReader(process.getInputStream()));
while (!isStop && (line = outReader.readLine()) != null) {
- LOG.info("monitor log: " + line);
+ outputBuffer.append(line + '\n');
Review comment:
why not just output to the `outputStream`? So that we don't need to
buffer a log of content in memory?
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java
##########
@@ -701,6 +702,20 @@ protected long getEtlStartTimestamp() {
return etlStartTimestamp;
}
+ public SparkLoadAppHandle getHandle() {
+ return sparkLoadAppHandle;
+ }
+
+ public void clearSparkLauncherLog() {
+ String logPath = sparkLoadAppHandle.getLogPath();
Review comment:
Are you sure the `sparkLoadAppHandle` is not null here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
