github-actions[bot] commented on code in PR #23498:
URL: https://github.com/apache/doris/pull/23498#discussion_r1306960227
##########
be/src/udf/udf.h:
##########
@@ -79,6 +79,12 @@ class FunctionContext {
return _check_overflow_for_decimal = check_overflow_for_decimal;
}
+ void set_string_as_jsonb_string(bool string_as_jsonb_string) {
+ _string_as_jsonb_string = string_as_jsonb_string;
+ }
+
+ bool string_as_jsonb_string() const { return _string_as_jsonb_string; }
Review Comment:
warning: function 'string_as_jsonb_string' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool string_as_jsonb_string() const { return
_string_as_jsonb_string; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
