github-actions[bot] commented on PR #23618:
URL: https://github.com/apache/doris/pull/23618#issuecomment-1697044894
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/6010137113";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In env.sh line 147:
cov_tools=($(find ${DORIS_CLANG_HOME} -name "llvm-cov*"))
^-- SC2207 (warning): Prefer mapfile or read -a to split
command output (or quote to avoid splitting).
^-----------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
cov_tools=($(find "${DORIS_CLANG_HOME}" -name "llvm-cov*"))
In env.sh line 151:
export LLVM_COV="$(command -v llvm-cov)"
^------^ SC2155 (warning): Declare and assign separately to
avoid masking return values.
In env.sh line 153:
cov_tools=($(find ${DORIS_CLANG_HOME} -name "llvm-profdata*"))
^-- SC2207 (warning): Prefer mapfile or read -a to split
command output (or quote to avoid splitting).
^-----------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
cov_tools=($(find "${DORIS_CLANG_HOME}" -name "llvm-profdata*"))
In env.sh line 157:
export LLVM_PROFDATA="$(command -v llvm-profdata)"
^-----------^ SC2155 (warning): Declare and assign separately
to avoid masking return values.
In run-be-ut.sh line 391:
rm -rf ${DORIS_TEST_BINARY_DIR}/report
^----------------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
rm -rf "${DORIS_TEST_BINARY_DIR}"/report
In run-be-ut.sh line 393:
$LLVM_PROFDATA merge -o ${profdata} ${profraw}
^------------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^---------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^--------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
Did you mean:
${LLVM_PROFDATA} merge -o "${profdata}" "${profraw}"
In run-be-ut.sh line 394:
$LLVM_COV show -output-dir=${DORIS_TEST_BINARY_DIR}/report
-format=html \
^-------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^----------------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
Did you mean:
${LLVM_COV} show -output-dir="${DORIS_TEST_BINARY_DIR}"/report
-format=html \
In run-be-ut.sh line 396:
-instr-profile=${profdata} \
^---------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
-instr-profile="${profdata}" \
In run-be-ut.sh line 397:
-object=${test}
^-----^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
-object="${test}"
For more information:
https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to
...
https://www.shellcheck.net/wiki/SC2207 -- Prefer mapfile or read -a to
spli...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- run-be-ut.sh.orig
+++ run-be-ut.sh
@@ -387,7 +387,7 @@
if [[ -f "${test}" ]]; then
if [[ "_${DENABLE_CLANG_COVERAGE}" == "_ON" ]]; then
LLVM_PROFILE_FILE="${profraw}" "${test}"
--gtest_output="xml:${GTEST_OUTPUT_DIR}/${file_name}.xml"
--gtest_print_time=true "${FILTER}"
- if [[ -d ${DORIS_TEST_BINARY_DIR}/report ]];then
+ if [[ -d ${DORIS_TEST_BINARY_DIR}/report ]]; then
rm -rf ${DORIS_TEST_BINARY_DIR}/report
fi
$LLVM_PROFDATA merge -o ${profdata} ${profraw}
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
