morningman commented on a change in pull request #4502:
URL: https://github.com/apache/incubator-doris/pull/4502#discussion_r487525949
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/ResourceMgr.java
##########
@@ -52,7 +55,7 @@
private static final Logger LOG = LogManager.getLogger(ResourceMgr.class);
public static final ImmutableList<String> RESOURCE_PROC_NODE_TITLE_NAMES =
new ImmutableList.Builder<String>()
- .add("Name").add("ResourceType").add("Key").add("Value")
+ .add("NAME").add("RESOURCETYPE").add("KEY").add("VALUE")
Review comment:
Why changing them to uppercase?
And as @xy720 said, better not using `KEY`, I prefer `Item`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
