github-actions[bot] commented on PR #23982:
URL: https://github.com/apache/doris/pull/23982#issuecomment-1708016026
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/6095420760";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 288:
if [[ "$?" = "0" ]]; then
^--^ SC2181 (style): Check exit code directly with e.g. 'if
mycmd;', not indirectly with $?.
For more information:
https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with
e.g...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -286,9 +286,9 @@
# try to get submodule's current commit
submodule_commit=$(git ls-tree HEAD "${submodule_path}" | awk
'{print $3}')
if [[ "$?" = "0" ]]; then
- commit_specific_url=$(echo "${archive_url}" | sed
"s/refs\/heads/${submodule_commit}/")
+ commit_specific_url=$(echo "${archive_url}" | sed
"s/refs\/heads/${submodule_commit}/")
else
- commit_specific_url="${archive_url}"
+ commit_specific_url="${archive_url}"
fi
set -e
echo "Update ${submodule_name} submodule failed, start to download
and extract ${commit_specific_url}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
