xxiao2018 commented on code in PR #23485:
URL: https://github.com/apache/doris/pull/23485#discussion_r1319439287
##########
fe/fe-core/src/test/java/org/apache/doris/analysis/S3TvfLoadStmtTest.java:
##########
@@ -37,18 +37,19 @@
import com.google.common.collect.Sets;
import mockit.Expectations;
import mockit.Injectable;
+import org.apache.doris.utframe.TestWithFeService;
import org.apache.hadoop.util.Lists;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
import java.io.StringReader;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Set;
-public class S3TvfLoadStmtTest {
+public class S3TvfLoadStmtTest extends TestWithFeService {
Review Comment:
Why modify this?
##########
fe/fe-core/src/main/java/org/apache/doris/common/FeConstants.java:
##########
@@ -49,6 +49,7 @@ public class FeConstants {
// set to true to skip some step when running FE unit test
public static boolean runningUnitTest = false;
+ public static Object unitTestConstant = null;
Review Comment:
What is this for? Add comment
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/LoadCommand.java:
##########
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.BulkLoadDataDesc;
+import org.apache.doris.analysis.BulkStorageDesc;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.TableIf;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.NereidsException;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.profile.Profile;
+import org.apache.doris.datasource.property.constants.S3Properties;
+import org.apache.doris.load.loadv2.LoadTask;
+import org.apache.doris.nereids.analyzer.UnboundAlias;
+import org.apache.doris.nereids.analyzer.UnboundOlapTableSink;
+import org.apache.doris.nereids.analyzer.UnboundSlot;
+import org.apache.doris.nereids.analyzer.UnboundTVFRelation;
+import org.apache.doris.nereids.trees.expressions.CaseWhen;
+import org.apache.doris.nereids.trees.expressions.EqualTo;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.Properties;
+import org.apache.doris.nereids.trees.expressions.StatementScopeIdGenerator;
+import org.apache.doris.nereids.trees.expressions.WhenClause;
+import org.apache.doris.nereids.trees.expressions.literal.TinyIntLiteral;
+import org.apache.doris.nereids.trees.plans.Explainable;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.logical.LogicalCheckPolicy;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.nereids.util.ExpressionUtils;
+import org.apache.doris.nereids.util.RelationUtil;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.QueryStateException;
+import org.apache.doris.qe.StmtExecutor;
+import org.apache.doris.tablefunction.ExternalFileTableValuedFunction;
+import org.apache.doris.tablefunction.HdfsTableValuedFunction;
+import org.apache.doris.tablefunction.S3TableValuedFunction;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.VerifyException;
+import com.google.common.collect.ImmutableList;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+
+/**
+ * export table
+ */
+public class LoadCommand extends Command implements ForwardWithSync,
Explainable {
+ public static final Logger LOG = LogManager.getLogger(LoadCommand.class);
+ private final String labelName;
+ private final BulkStorageDesc bulkStorageDesc;
+ private final List<BulkLoadDataDesc> sourceInfos;
+ private final Map<String, String> properties;
+ private final String comment;
+ private final List<LogicalPlan> plans = new ArrayList<>();
+ private Profile profile;
+
+ /**
+ * constructor of ExportCommand
+ */
+ public LoadCommand(String labelName, List<BulkLoadDataDesc> sourceInfos,
BulkStorageDesc bulkStorageDesc,
+ Map<String, String> properties, String comment) {
+ super(PlanType.LOAD_COMMAND);
+ this.labelName = Objects.requireNonNull(labelName.trim(), "labelName
should not null");
+ this.sourceInfos = Objects.requireNonNull(sourceInfos, "sourceInfos
should not null");
+ this.properties = Objects.requireNonNull(properties, "properties
should not null");
+ this.bulkStorageDesc = Objects.requireNonNull(bulkStorageDesc,
"bulkStorageDesc should not null");
+ this.comment = Objects.requireNonNull(comment, "comment should not
null");
+ }
+
+ /**
+ * for test print
+ * @param ctx context
+ * @return parsed insert into plan
+ */
+ @VisibleForTesting
+ public List<LogicalPlan> parseToInsertIntoPlan(ConnectContext ctx) throws
AnalysisException {
+ List<LogicalPlan> plans = new ArrayList<>();
+ for (BulkLoadDataDesc dataDesc : sourceInfos) {
+ ctx.getState().setNereids(true);
+ plans.add(completeQueryPlan(ctx, dataDesc));
+ }
+ return plans;
+ }
+
+ @Override
+ public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
+ this.profile = new Profile("Query",
ctx.getSessionVariable().enableProfile);
+ // TODO: begin txn form multi insert sql
+ profile.getSummaryProfile().setQueryBeginTime();
+ for (BulkLoadDataDesc dataDesc : sourceInfos) {
+ ctx.getState().setNereids(true);
+ plans.add(new InsertIntoTableCommand(completeQueryPlan(ctx,
dataDesc), Optional.of(labelName), false));
+ }
+ profile.getSummaryProfile().setQueryPlanFinishTime();
+ executeInsertStmtPlan(ctx, executor, plans);
+ }
+
+ private LogicalPlan completeQueryPlan(ConnectContext ctx, BulkLoadDataDesc
dataDesc)
+ throws AnalysisException {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("nereids load stmt before conversion: {}",
dataDesc.toSql());
+ }
+ // build source columns, add select and insert node.
+ List<String> sinkCols = new ArrayList<>();
+ // contains the map of olap column to FileFieldNames,
ColumnMappingList, ColumnsFromPath.
+ Map<String, NamedExpression> originSinkToSourceMap = new
LinkedHashMap<>();
+ OlapTable olapTable = getOlapTable(ctx, dataDesc);
+ buildSinkColumns(olapTable, dataDesc, sinkCols, originSinkToSourceMap);
+
+ Map<String, String> properties = getTvfProperties(dataDesc,
bulkStorageDesc);
+ // mapping sink colum to mapping expression
+ if (!dataDesc.getColumnMappingList().isEmpty()) {
+ for (Expression mappingExpr : dataDesc.getColumnMappingList()) {
+ if (!(mappingExpr instanceof EqualTo)) {
+ continue;
+ }
+ String mappingColumn = ((EqualTo) mappingExpr).left().toSql();
+ if (originSinkToSourceMap.containsKey(mappingColumn)) {
+ Expression mappingExprAlias = ((EqualTo)
mappingExpr).right();
+ originSinkToSourceMap.put(mappingColumn, new
UnboundAlias(mappingExprAlias, mappingColumn));
+ }
+ }
+ }
+
+ for (String columnFromPath : dataDesc.getColumnsFromPath()) {
+ sinkCols.add(columnFromPath);
+ // columnFromPath will be parsed by BE, put columns as placeholder.
+ originSinkToSourceMap.put(columnFromPath, new
UnboundSlot(columnFromPath));
+ }
+
+ checkAndAddSequenceCol(olapTable, dataDesc, sinkCols,
originSinkToSourceMap);
+ // build source columns
+ List<NamedExpression> selectLists = new
ArrayList<>(originSinkToSourceMap.values());
+ LogicalPlan tvfLogicalPlan = new LogicalProject<>(selectLists,
// add select
+ new LogicalFilter<>(buildTvfFilter(dataDesc,
originSinkToSourceMap), // add filter
+ new
LogicalCheckPolicy<>(getUnboundTVFRelation(properties)))); // add
relation
+ // TODO: 1. get column schema in tvf metadata.
+ // TODO: 2. rewrite pre filter and source projects on tvfLogicalPlan
when use csv or text format.
+ boolean isPartialUpdate = olapTable.getEnableUniqueKeyMergeOnWrite()
+ && sinkCols.size() < olapTable.getColumns().size();
+ return new UnboundOlapTableSink<>(dataDesc.getNameParts(), sinkCols,
ImmutableList.of(),
+ dataDesc.getPartitionNames(), isPartialUpdate, tvfLogicalPlan);
+ }
+
+ private static String getColumnValueFromPath(String columnFromPath, String
columnName) {
+ // TODO: get partition value from path ?
+ return null;
+ }
+
+ private static void buildSinkColumns(OlapTable olapTable, BulkLoadDataDesc
dataDesc, List<String> sinkCols,
Review Comment:
Add some comment to explain the conversion here
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/LoadCommand.java:
##########
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.BulkLoadDataDesc;
+import org.apache.doris.analysis.BulkStorageDesc;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.TableIf;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.NereidsException;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.profile.Profile;
+import org.apache.doris.datasource.property.constants.S3Properties;
+import org.apache.doris.load.loadv2.LoadTask;
+import org.apache.doris.nereids.analyzer.UnboundAlias;
+import org.apache.doris.nereids.analyzer.UnboundOlapTableSink;
+import org.apache.doris.nereids.analyzer.UnboundSlot;
+import org.apache.doris.nereids.analyzer.UnboundTVFRelation;
+import org.apache.doris.nereids.trees.expressions.CaseWhen;
+import org.apache.doris.nereids.trees.expressions.EqualTo;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.Properties;
+import org.apache.doris.nereids.trees.expressions.StatementScopeIdGenerator;
+import org.apache.doris.nereids.trees.expressions.WhenClause;
+import org.apache.doris.nereids.trees.expressions.literal.TinyIntLiteral;
+import org.apache.doris.nereids.trees.plans.Explainable;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.logical.LogicalCheckPolicy;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.nereids.util.ExpressionUtils;
+import org.apache.doris.nereids.util.RelationUtil;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.QueryStateException;
+import org.apache.doris.qe.StmtExecutor;
+import org.apache.doris.tablefunction.ExternalFileTableValuedFunction;
+import org.apache.doris.tablefunction.HdfsTableValuedFunction;
+import org.apache.doris.tablefunction.S3TableValuedFunction;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.VerifyException;
+import com.google.common.collect.ImmutableList;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+
+/**
+ * export table
+ */
+public class LoadCommand extends Command implements ForwardWithSync,
Explainable {
+ public static final Logger LOG = LogManager.getLogger(LoadCommand.class);
+ private final String labelName;
+ private final BulkStorageDesc bulkStorageDesc;
+ private final List<BulkLoadDataDesc> sourceInfos;
+ private final Map<String, String> properties;
+ private final String comment;
+ private final List<LogicalPlan> plans = new ArrayList<>();
+ private Profile profile;
+
+ /**
+ * constructor of ExportCommand
+ */
+ public LoadCommand(String labelName, List<BulkLoadDataDesc> sourceInfos,
BulkStorageDesc bulkStorageDesc,
+ Map<String, String> properties, String comment) {
+ super(PlanType.LOAD_COMMAND);
+ this.labelName = Objects.requireNonNull(labelName.trim(), "labelName
should not null");
+ this.sourceInfos = Objects.requireNonNull(sourceInfos, "sourceInfos
should not null");
+ this.properties = Objects.requireNonNull(properties, "properties
should not null");
+ this.bulkStorageDesc = Objects.requireNonNull(bulkStorageDesc,
"bulkStorageDesc should not null");
+ this.comment = Objects.requireNonNull(comment, "comment should not
null");
+ }
+
+ /**
+ * for test print
+ * @param ctx context
+ * @return parsed insert into plan
+ */
+ @VisibleForTesting
+ public List<LogicalPlan> parseToInsertIntoPlan(ConnectContext ctx) throws
AnalysisException {
+ List<LogicalPlan> plans = new ArrayList<>();
+ for (BulkLoadDataDesc dataDesc : sourceInfos) {
+ ctx.getState().setNereids(true);
Review Comment:
Do we need to set nereids for each BulkLoadDataDesc?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/LoadCommand.java:
##########
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.BulkLoadDataDesc;
+import org.apache.doris.analysis.BulkStorageDesc;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.TableIf;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.NereidsException;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.profile.Profile;
+import org.apache.doris.datasource.property.constants.S3Properties;
+import org.apache.doris.load.loadv2.LoadTask;
+import org.apache.doris.nereids.analyzer.UnboundAlias;
+import org.apache.doris.nereids.analyzer.UnboundOlapTableSink;
+import org.apache.doris.nereids.analyzer.UnboundSlot;
+import org.apache.doris.nereids.analyzer.UnboundTVFRelation;
+import org.apache.doris.nereids.trees.expressions.CaseWhen;
+import org.apache.doris.nereids.trees.expressions.EqualTo;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.Properties;
+import org.apache.doris.nereids.trees.expressions.StatementScopeIdGenerator;
+import org.apache.doris.nereids.trees.expressions.WhenClause;
+import org.apache.doris.nereids.trees.expressions.literal.TinyIntLiteral;
+import org.apache.doris.nereids.trees.plans.Explainable;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.logical.LogicalCheckPolicy;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.nereids.util.ExpressionUtils;
+import org.apache.doris.nereids.util.RelationUtil;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.QueryStateException;
+import org.apache.doris.qe.StmtExecutor;
+import org.apache.doris.tablefunction.ExternalFileTableValuedFunction;
+import org.apache.doris.tablefunction.HdfsTableValuedFunction;
+import org.apache.doris.tablefunction.S3TableValuedFunction;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.VerifyException;
+import com.google.common.collect.ImmutableList;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+
+/**
+ * export table
+ */
+public class LoadCommand extends Command implements ForwardWithSync,
Explainable {
+ public static final Logger LOG = LogManager.getLogger(LoadCommand.class);
+ private final String labelName;
+ private final BulkStorageDesc bulkStorageDesc;
+ private final List<BulkLoadDataDesc> sourceInfos;
+ private final Map<String, String> properties;
+ private final String comment;
+ private final List<LogicalPlan> plans = new ArrayList<>();
+ private Profile profile;
+
+ /**
+ * constructor of ExportCommand
+ */
+ public LoadCommand(String labelName, List<BulkLoadDataDesc> sourceInfos,
BulkStorageDesc bulkStorageDesc,
+ Map<String, String> properties, String comment) {
+ super(PlanType.LOAD_COMMAND);
+ this.labelName = Objects.requireNonNull(labelName.trim(), "labelName
should not null");
+ this.sourceInfos = Objects.requireNonNull(sourceInfos, "sourceInfos
should not null");
+ this.properties = Objects.requireNonNull(properties, "properties
should not null");
+ this.bulkStorageDesc = Objects.requireNonNull(bulkStorageDesc,
"bulkStorageDesc should not null");
+ this.comment = Objects.requireNonNull(comment, "comment should not
null");
+ }
+
+ /**
+ * for test print
+ * @param ctx context
+ * @return parsed insert into plan
+ */
+ @VisibleForTesting
+ public List<LogicalPlan> parseToInsertIntoPlan(ConnectContext ctx) throws
AnalysisException {
+ List<LogicalPlan> plans = new ArrayList<>();
+ for (BulkLoadDataDesc dataDesc : sourceInfos) {
+ ctx.getState().setNereids(true);
+ plans.add(completeQueryPlan(ctx, dataDesc));
+ }
+ return plans;
+ }
+
+ @Override
+ public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
+ this.profile = new Profile("Query",
ctx.getSessionVariable().enableProfile);
+ // TODO: begin txn form multi insert sql
+ profile.getSummaryProfile().setQueryBeginTime();
+ for (BulkLoadDataDesc dataDesc : sourceInfos) {
+ ctx.getState().setNereids(true);
+ plans.add(new InsertIntoTableCommand(completeQueryPlan(ctx,
dataDesc), Optional.of(labelName), false));
+ }
+ profile.getSummaryProfile().setQueryPlanFinishTime();
+ executeInsertStmtPlan(ctx, executor, plans);
+ }
+
+ private LogicalPlan completeQueryPlan(ConnectContext ctx, BulkLoadDataDesc
dataDesc)
+ throws AnalysisException {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("nereids load stmt before conversion: {}",
dataDesc.toSql());
+ }
+ // build source columns, add select and insert node.
+ List<String> sinkCols = new ArrayList<>();
+ // contains the map of olap column to FileFieldNames,
ColumnMappingList, ColumnsFromPath.
+ Map<String, NamedExpression> originSinkToSourceMap = new
LinkedHashMap<>();
+ OlapTable olapTable = getOlapTable(ctx, dataDesc);
+ buildSinkColumns(olapTable, dataDesc, sinkCols, originSinkToSourceMap);
+
+ Map<String, String> properties = getTvfProperties(dataDesc,
bulkStorageDesc);
+ // mapping sink colum to mapping expression
+ if (!dataDesc.getColumnMappingList().isEmpty()) {
+ for (Expression mappingExpr : dataDesc.getColumnMappingList()) {
+ if (!(mappingExpr instanceof EqualTo)) {
+ continue;
+ }
+ String mappingColumn = ((EqualTo) mappingExpr).left().toSql();
+ if (originSinkToSourceMap.containsKey(mappingColumn)) {
+ Expression mappingExprAlias = ((EqualTo)
mappingExpr).right();
+ originSinkToSourceMap.put(mappingColumn, new
UnboundAlias(mappingExprAlias, mappingColumn));
+ }
+ }
+ }
+
+ for (String columnFromPath : dataDesc.getColumnsFromPath()) {
+ sinkCols.add(columnFromPath);
+ // columnFromPath will be parsed by BE, put columns as placeholder.
Review Comment:
I think the columnFromPath should be parsed by FE, and after parsing, we
only need to add the parsed constant value here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
