morningman commented on a change in pull request #4683:
URL: https://github.com/apache/incubator-doris/pull/4683#discussion_r496339733
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateRoutineLoadStmt.java
##########
@@ -297,6 +311,19 @@ public void checkDBTable(Analyzer analyzer) throws
AnalysisException {
if (Strings.isNullOrEmpty(tableName)) {
throw new AnalysisException("Table name should not be null");
}
+ Database db = Catalog.getCurrentCatalog().getDb(dbName);
+ if (db == null) {
+ throw new AnalysisException("database: " + dbName + "not found.");
Review comment:
```suggestion
throw new AnalysisException("database: " + dbName + " not
found.");
```
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/BrokerFileGroup.java
##########
@@ -385,6 +385,13 @@ public void write(DataOutput out) throws IOException {
// src table
out.writeLong(srcTableId);
out.writeBoolean(isLoadFromTable);
+ Text.writeString(out, mergeType.name());
Review comment:
I think we can change this class to GSON DeSer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
