morningman commented on code in PR #23978:
URL: https://github.com/apache/doris/pull/23978#discussion_r1322613119
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java:
##########
@@ -97,36 +97,54 @@ public void analyzeDb(DatabaseIf<TableIf> databaseIf) {
}
}
- public List<AnalysisInfo> constructAnalysisInfo(DatabaseIf<? extends
TableIf> db) {
+ protected List<AnalysisInfo> constructAnalysisInfo(DatabaseIf<? extends
TableIf> db) {
List<AnalysisInfo> analysisInfos = new ArrayList<>();
for (TableIf table : db.getTables()) {
- if (table instanceof View) {
+ if (table instanceof View || skip(table)) {
Review Comment:
I suggest to put the check `table instanceof View` into `skip` too,
And better only list the supported table type, not `non-supported` type,
In case we may add some new type of table in future and miss to modify here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
