zhannngchen commented on code in PR #21773:
URL: https://github.com/apache/doris/pull/21773#discussion_r1323079040
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -714,7 +715,8 @@ Status BetaRowsetWriter::add_segment(uint32_t segment_id,
SegmentStatistics& seg
}
}
if (_context.mow_context != nullptr) {
- RETURN_IF_ERROR(_generate_delete_bitmap(segment_id));
+ RETURN_IF_ERROR(_generate_delete_bitmap(
+ segment_id,
_context.tablet_schema->is_unique_key_ignore_mode()));
Review Comment:
You also need to consider publish phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
