cambyzju commented on code in PR #24264:
URL: https://github.com/apache/doris/pull/24264#discussion_r1324441819
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -1565,21 +1565,26 @@ private String jobPropertiesToJsonString() {
jobProperties.put("precedingFilter", precedingFilter == null ?
STAR_STRING : precedingFilter.toSql());
jobProperties.put("whereExpr", whereExpr == null ? STAR_STRING :
whereExpr.toSql());
if (getFormat().equalsIgnoreCase("json")) {
- jobProperties.put("dataFormat", "json");
+ jobProperties.put(PROPS_FORMAT, "json");
Review Comment:
yes，it maybe. But the format should be the same, otherwise there is a BUG.
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -1565,21 +1565,26 @@ private String jobPropertiesToJsonString() {
jobProperties.put("precedingFilter", precedingFilter == null ?
STAR_STRING : precedingFilter.toSql());
jobProperties.put("whereExpr", whereExpr == null ? STAR_STRING :
whereExpr.toSql());
if (getFormat().equalsIgnoreCase("json")) {
- jobProperties.put("dataFormat", "json");
+ jobProperties.put(PROPS_FORMAT, "json");
Review Comment:
yes，it maybe. But the format should be the same, otherwise there is a BUG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
