morrySnow commented on code in PR #22088:
URL: https://github.com/apache/doris/pull/22088#discussion_r1326131940
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -213,7 +219,8 @@ private List<Long> bindPartitionIds(OlapTable table,
List<String> partitions) {
private List<Column> bindTargetColumns(OlapTable table, List<String>
colsName) {
return colsName.isEmpty()
- ? table.getFullSchema().stream().filter(column ->
column.isVisible()
+ ? table.getFullSchema().stream().filter(column ->
(column.isVisible()
+ || column.isSequenceColumn())
Review Comment:
add comment to explain why add isSequenceColumn()
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -213,7 +219,8 @@ private List<Long> bindPartitionIds(OlapTable table,
List<String> partitions) {
private List<Column> bindTargetColumns(OlapTable table, List<String>
colsName) {
return colsName.isEmpty()
- ? table.getFullSchema().stream().filter(column ->
column.isVisible()
+ ? table.getFullSchema().stream().filter(column ->
(column.isVisible()
Review Comment:
it is better return ImmutableList in `collect`
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateTableCommand.java:
##########
@@ -107,7 +107,7 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
} else if (i == 0 && dataType.isStringType()) {
dataType =
VarcharType.createVarcharType(ScalarType.MAX_VARCHAR_LENGTH);
}
- columnsOfQuery.add(new ColumnDefinition(s.getName(), dataType,
s.nullable()));
+ columnsOfQuery.add(new ColumnDefinition(s.getName(), dataType,
!s.isColumnFromTable() || s.nullable()));
Review Comment:
add comment to explain it
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -226,6 +233,17 @@ private List<Column> bindTargetColumns(OlapTable table,
List<String> colsName) {
}).collect(Collectors.toList());
}
+ private void maybeFallBackAggStateTypeColumn(Column column, ConnectContext
ctx) {
Review Comment:
i think u should add aggstate type into
`org.apache.doris.nereids.rules.rewrite.CheckDataTypes#UNSUPPORTED_TYPE`
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/UpdateCommand.java:
##########
@@ -105,7 +105,7 @@ public LogicalPlan completeQueryPlan(ConnectContext ctx,
LogicalPlan logicalQuer
List<NamedExpression> selectItems = Lists.newArrayList();
String tableName = tableAlias != null ? tableAlias :
targetTable.getName();
for (Column column : targetTable.getFullSchema()) {
- if (!column.isVisible()) {
+ if (!column.isVisible() && !column.isSequenceColumn()) {
Review Comment:
add comment to explain it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
