morningman commented on issue #4797:
URL: 
https://github.com/apache/incubator-doris/issues/4797#issuecomment-716938157


   > all the previous rowsets corresponding to MemTable in `vector<MemTable>` 
will be deleted
   
   This is not easy to implement. the rowsets which already been flushed to the 
disk may be merged by cumulative or base compaction, so that you can not find 
all origin rowsets.
   If you implement what you designed, you need to consider the existing 
compaction logic. As far as I can think of, I am not sure whether the 
additional memory and IO overhead brought by this approach will have other 
effects.
   
   In fact, this is an implementation of "Group Commit". And I think a readable 
Memtable and WAL may be a better way.
   
   I remember that @vagetablechicken and @decster was try to implement "Memory 
Engine #3382". Can we go that way?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to