luozenglin commented on code in PR #24229:
URL: https://github.com/apache/doris/pull/24229#discussion_r1328619641
##########
be/src/olap/storage_engine.cpp:
##########
@@ -357,6 +358,15 @@ Status
StorageEngine::get_all_data_dir_info(std::vector<DataDirInfo>* data_dir_i
return res;
}
+Status StorageEngine::get_log_dir_info(LogDirInfo* log_dir_infos) {
+ Status res = Status::OK();
+ _log_dir->health_check();
+ _log_dir->update_capacity();
+ LogDirInfo dir_info = _log_dir->get_dir_info();
Review Comment:
Why not just pass the log_dir_infos pointer as an argument to get_dir_info()
or move dir_info to log_dir_infos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
