liaoxin01 commented on code in PR #24570:
URL: https://github.com/apache/doris/pull/24570#discussion_r1328756427
##########
be/src/olap/cumulative_compaction.cpp:
##########
@@ -95,6 +97,18 @@ Status CumulativeCompaction::execute_compact_impl() {
VLOG_CRITICAL << "after cumulative compaction, current cumulative point is
"
<< _tablet->cumulative_layer_point() << ", tablet=" <<
_tablet->full_name();
+ if (_tablet->enable_unique_key_merge_on_write()) {
Review Comment:
duplicated code. Implement this function in the base class？
##########
be/src/olap/cumulative_compaction.cpp:
##########
@@ -95,6 +97,18 @@ Status CumulativeCompaction::execute_compact_impl() {
VLOG_CRITICAL << "after cumulative compaction, current cumulative point is
"
<< _tablet->cumulative_layer_point() << ", tablet=" <<
_tablet->full_name();
+ if (_tablet->enable_unique_key_merge_on_write()) {
Review Comment:
duplicated code. Implement this function in the base class？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
