xiaokang commented on code in PR #24631:
URL: https://github.com/apache/doris/pull/24631#discussion_r1330090512
##########
be/src/vec/functions/function_jsonb.cpp:
##########
@@ -987,6 +998,7 @@ struct JsonbExtractDouble : public
JsonbExtractImpl<JsonbTypeDouble> {
struct JsonbExtractString : public JsonbExtractStringImpl<JsonbTypeString> {
static constexpr auto name = "json_extract_string";
static constexpr auto alias = "jsonb_extract_string";
+ static constexpr auto partial_alias = "get_json_string";
Review Comment:
alias2
##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -1783,6 +1783,8 @@
[['get_json_string'], 'STRING', ['STRING', 'STRING'],
'ALWAYS_NULLABLE'],
[['get_json_bigint'], 'BIGINT', ['VARCHAR', 'VARCHAR'],
'ALWAYS_NULLABLE'],
[['get_json_bigint'], 'BIGINT', ['STRING', 'STRING'],
'ALWAYS_NULLABLE'],
+ [['get_json_string'], 'STRING', ['JSONB', 'VARCHAR'],
'ALWAYS_NULLABLE'],
Review Comment:
process other get_json_xxx
##########
be/src/vec/functions/simple_function_factory.h:
##########
@@ -177,6 +177,11 @@ class SimpleFunctionFactory {
auto iter = function_creators.find(key_str);
if (iter == function_creators.end()) {
LOG(WARNING) << fmt::format("Function signature {} is not found",
key_str);
+ auto refind_iter = function_creators.find(name);
+ if (refind_iter != function_creators.end()) {
+ LOG(WARNING) << "find function without alisa, original
function is: " << name;
+ return refind_iter->second()->build(arguments, return_type);
Review Comment:
why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
