yiguolei commented on code in PR #22655:
URL: https://github.com/apache/doris/pull/22655#discussion_r1330920295
##########
be/src/vec/common/allocator.cpp:
##########
@@ -177,7 +177,9 @@ void Allocator<clear_memory_, mmap_populate,
use_mmap>::throw_bad_alloc(
template <bool clear_memory_, bool mmap_populate, bool use_mmap>
void* Allocator<clear_memory_, mmap_populate, use_mmap>::alloc(size_t size,
size_t alignment) {
- doris::thread_context()->large_memory_check = false;
+ if (doris::enable_thread_catch_bad_alloc) {
+ doris::thread_context()->large_memory_check = false;
Review Comment:
not modify this line. maybe we could delete large_memory_check, it should
always be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
