github-actions[bot] commented on code in PR #24768:
URL: https://github.com/apache/doris/pull/24768#discussion_r1333825841
##########
be/src/io/cache/block/cached_remote_file_reader.h:
##########
@@ -44,7 +44,7 @@
Status close() override;
- const Path& path() const override { return _remote_file_reader->path(); }
+ const Path& path() const { return _remote_file_reader->path(); }
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
const Path& path() const override { return _remote_file_reader->path(); }
```
##########
be/src/io/cache/block/cached_remote_file_reader.h:
##########
@@ -44,7 +44,7 @@ class CachedRemoteFileReader final : public FileReader {
Status close() override;
- const Path& path() const override { return _remote_file_reader->path(); }
+ const Path& path() const { return _remote_file_reader->path(); }
Review Comment:
warning: function 'path' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const Path& path() const { return
_remote_file_reader->path(); }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
