github-actions[bot] commented on code in PR #24771:
URL: https://github.com/apache/doris/pull/24771#discussion_r1333831435
##########
be/test/vec/function/function_bitmap_test.cpp:
##########
@@ -430,6 +430,21 @@ TEST(function_bitmap_test, function_bitmap_and_not_count) {
check_function<DataTypeInt64, true>(func_name, input_types, data_set);
}
+TEST(function_bitmap_test, function_bitmap_and_not_count_alias) {
+ std::string func_name = "bitmap_andnot_count";
Review Comment:
warning: variable 'func_name' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::string func_name = 0 = "bitmap_andnot_count";
```
##########
be/test/vec/function/function_bitmap_test.cpp:
##########
@@ -430,6 +430,21 @@
check_function<DataTypeInt64, true>(func_name, input_types, data_set);
}
+TEST(function_bitmap_test, function_bitmap_and_not_count_alias) {
+ std::string func_name = "bitmap_andnot_count";
+ InputTypeSet input_types = {TypeIndex::BitMap, TypeIndex::BitMap};
Review Comment:
warning: variable 'input_types' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
InputTypeSet input_types = 0 = {TypeIndex::BitMap, TypeIndex::BitMap};
```
##########
be/test/vec/function/function_bitmap_test.cpp:
##########
@@ -430,6 +430,21 @@
check_function<DataTypeInt64, true>(func_name, input_types, data_set);
}
+TEST(function_bitmap_test, function_bitmap_and_not_count_alias) {
+ std::string func_name = "bitmap_andnot_count";
+ InputTypeSet input_types = {TypeIndex::BitMap, TypeIndex::BitMap};
+ BitmapValue bitmap1({1, 2, 3});
+ BitmapValue bitmap2({3, 4, std::numeric_limits<uint64_t>::min()});
+ BitmapValue bitmap3({33, 5, std::numeric_limits<uint64_t>::max()});
+ BitmapValue empty_bitmap;
+
+ DataSet data_set = {{{&bitmap1, &empty_bitmap}, (int64_t)3}, //1,2,3
Review Comment:
warning: variable 'data_set' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
DataSet data_set = 0 = {{{&bitmap1, &empty_bitmap}, (int64_t)3}, //1,2,3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
