zhannngchen commented on code in PR #24778:
URL: https://github.com/apache/doris/pull/24778#discussion_r1333964760
##########
be/src/olap/compaction.cpp:
##########
@@ -134,7 +134,7 @@ Status Compaction::do_compaction(int64_t permits) {
<< ", before=" << checksum_before << ",
checksum_after=" << checksum_after;
}
}
- _load_segment_to_cache();
+ RETURN_IF_ERROR(_load_segment_to_cache());
Review Comment:
It's not necessary to return error here?
`_load_segment_to_cache` should be a best effort optimization, when it fail,
should just impact some performance, but not make the compaction job fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
