github-actions[bot] commented on code in PR #24812:
URL: https://github.com/apache/doris/pull/24812#discussion_r1334470750
##########
be/src/vec/data_types/serde/data_type_date64_serde.cpp:
##########
@@ -273,5 +273,53 @@ Status DataTypeDate64SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDate64SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = static_cast<const
ColumnVector<Int64>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
Review Comment:
warning: variable 'ptr' is not initialized [cppcoreguidelines-init-variables]
```suggestion
char* ptr = nullptr = (char*)malloc(BUFFER_UNIT_SIZE);
```
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -137,5 +137,54 @@ Status
DataTypeDateTimeV2SerDe::write_column_to_mysql(const IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDateTimeV2SerDe::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch,
+ int start, int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const
ColumnVector<UInt64>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
Review Comment:
warning: variable 'ptr' is not initialized [cppcoreguidelines-init-variables]
```suggestion
char* ptr = nullptr = (char*)malloc(BUFFER_UNIT_SIZE);
```
##########
be/src/vec/data_types/serde/data_type_date64_serde.cpp:
##########
@@ -273,5 +273,53 @@ Status DataTypeDate64SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDate64SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = static_cast<const
ColumnVector<Int64>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
Review Comment:
warning: variable 'cur_batch' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
orc::StringVectorBatch* cur_batch = nullptr =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
```
##########
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:
##########
@@ -142,5 +142,54 @@ Status DataTypeDateV2SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDateV2SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const
ColumnVector<UInt32>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
Review Comment:
warning: variable 'ptr' is not initialized [cppcoreguidelines-init-variables]
```suggestion
char* ptr = nullptr = (char*)malloc(BUFFER_UNIT_SIZE);
```
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -239,6 +239,80 @@ Status DataTypeNumberSerDe<T>::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+template <typename T>
+Status DataTypeNumberSerDe<T>::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const ColumnType&>(column).get_data();
+
+ if constexpr (std::is_same_v<T, Int128>) {
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column data to
orc file.");
+ }
+ StringRef bufferRef;
+ bufferRef.data = ptr;
+ bufferRef.size = BUFFER_UNIT_SIZE;
+ size_t offset = 0;
+ const size_t begin_off = offset;
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 0) {
+ continue;
+ }
+ std::string value_str = fmt::format("{}", col_data[row_id]);
+ size_t len = value_str.size();
+ while (bufferRef.size - BUFFER_RESERVED_SIZE < offset + len) {
+ char* new_ptr = (char*)malloc(bufferRef.size +
BUFFER_UNIT_SIZE);
+ if (!new_ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column
data to orc file.");
+ }
+ memcpy(new_ptr, bufferRef.data, bufferRef.size);
+ free(const_cast<char*>(bufferRef.data));
+ bufferRef.data = new_ptr;
+ bufferRef.size = bufferRef.size + BUFFER_UNIT_SIZE;
+ }
+ strcpy(const_cast<char*>(bufferRef.data) + offset,
value_str.c_str());
+ offset += len;
+ cur_batch->length[row_id] = len;
+ }
+ size_t data_off = 0;
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 1) {
+ cur_batch->data[row_id] = const_cast<char*>(bufferRef.data) +
begin_off + data_off;
+ data_off += cur_batch->length[row_id];
+ }
+ }
+ buffer_list.emplace_back(bufferRef);
+ cur_batch->numElements = end - start;
+ } else if constexpr ((std::is_integral<T>::value &&
std::is_signed<T>::value) ||
+ std::is_same_v<T, UInt8>) { // tinyint/smallint/..int
and boolean type
+ orc::LongVectorBatch* cur_batch =
dynamic_cast<orc::LongVectorBatch*>(orc_col_batch);
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 1) {
+ cur_batch->data[row_id] = col_data[row_id];
+ }
+ }
+ cur_batch->numElements = end - start;
+ } else if constexpr (IsFloatNumber<T>) {
+ orc::DoubleVectorBatch* cur_batch =
dynamic_cast<orc::DoubleVectorBatch*>(orc_col_batch);
+
+ for (size_t row_id = start; row_id < end; row_id++) {
Review Comment:
warning: variable 'cur_batch' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
DoubleVectorBatch* cur_batch = nullptr =
dynamic_cast<orc::DoubleVectorBatch*>(orc_col_batch);
```
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -239,6 +239,80 @@ Status DataTypeNumberSerDe<T>::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+template <typename T>
+Status DataTypeNumberSerDe<T>::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const ColumnType&>(column).get_data();
+
+ if constexpr (std::is_same_v<T, Int128>) {
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column data to
orc file.");
+ }
+ StringRef bufferRef;
+ bufferRef.data = ptr;
+ bufferRef.size = BUFFER_UNIT_SIZE;
+ size_t offset = 0;
+ const size_t begin_off = offset;
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 0) {
+ continue;
+ }
+ std::string value_str = fmt::format("{}", col_data[row_id]);
+ size_t len = value_str.size();
+ while (bufferRef.size - BUFFER_RESERVED_SIZE < offset + len) {
+ char* new_ptr = (char*)malloc(bufferRef.size +
BUFFER_UNIT_SIZE);
+ if (!new_ptr) {
Review Comment:
warning: variable 'new_ptr' is not initialized
[cppcoreguidelines-init-variables]
be/src/vec/data_types/serde/data_type_number_serde.cpp:271:
```diff
- r = (char*)malloc(bufferRef.size + BUFFER_UNIT_SIZE);
+ r = nullptr = (char*)malloc(bufferRef.size + BUFFER_UNIT_SIZE);
```
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -137,5 +137,54 @@ Status
DataTypeDateTimeV2SerDe::write_column_to_mysql(const IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDateTimeV2SerDe::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch,
+ int start, int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const
ColumnVector<UInt64>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
Review Comment:
warning: variable 'cur_batch' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
orc::StringVectorBatch* cur_batch = nullptr =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
```
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -239,6 +239,80 @@ Status DataTypeNumberSerDe<T>::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+template <typename T>
+Status DataTypeNumberSerDe<T>::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const ColumnType&>(column).get_data();
+
+ if constexpr (std::is_same_v<T, Int128>) {
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column data to
orc file.");
+ }
+ StringRef bufferRef;
+ bufferRef.data = ptr;
+ bufferRef.size = BUFFER_UNIT_SIZE;
+ size_t offset = 0;
+ const size_t begin_off = offset;
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 0) {
+ continue;
+ }
+ std::string value_str = fmt::format("{}", col_data[row_id]);
+ size_t len = value_str.size();
+ while (bufferRef.size - BUFFER_RESERVED_SIZE < offset + len) {
+ char* new_ptr = (char*)malloc(bufferRef.size +
BUFFER_UNIT_SIZE);
+ if (!new_ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column
data to orc file.");
+ }
+ memcpy(new_ptr, bufferRef.data, bufferRef.size);
+ free(const_cast<char*>(bufferRef.data));
+ bufferRef.data = new_ptr;
+ bufferRef.size = bufferRef.size + BUFFER_UNIT_SIZE;
+ }
+ strcpy(const_cast<char*>(bufferRef.data) + offset,
value_str.c_str());
+ offset += len;
+ cur_batch->length[row_id] = len;
+ }
+ size_t data_off = 0;
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 1) {
+ cur_batch->data[row_id] = const_cast<char*>(bufferRef.data) +
begin_off + data_off;
+ data_off += cur_batch->length[row_id];
+ }
+ }
+ buffer_list.emplace_back(bufferRef);
+ cur_batch->numElements = end - start;
+ } else if constexpr ((std::is_integral<T>::value &&
std::is_signed<T>::value) ||
+ std::is_same_v<T, UInt8>) { // tinyint/smallint/..int
and boolean type
+ orc::LongVectorBatch* cur_batch =
dynamic_cast<orc::LongVectorBatch*>(orc_col_batch);
+
+ for (size_t row_id = start; row_id < end; row_id++) {
Review Comment:
warning: variable 'cur_batch' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
rc::LongVectorBatch* cur_batch = nullptr =
dynamic_cast<orc::LongVectorBatch*>(orc_col_batch);
```
##########
be/src/vec/data_types/serde/data_type_date64_serde.cpp:
##########
@@ -273,5 +273,53 @@ Status DataTypeDate64SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDate64SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = static_cast<const
ColumnVector<Int64>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column data to orc
file.");
+ }
+ StringRef bufferRef;
+ bufferRef.data = ptr;
+ bufferRef.size = BUFFER_UNIT_SIZE;
+ size_t offset = 0;
+ const size_t begin_off = offset;
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 0) {
+ continue;
+ }
+
+ int len = binary_cast<Int64, VecDateTimeValue>(col_data[row_id])
+ .to_buffer(const_cast<char*>(bufferRef.data) +
offset);
+ while (bufferRef.size - BUFFER_RESERVED_SIZE < offset + len) {
+ char* new_ptr = (char*)malloc(bufferRef.size + BUFFER_UNIT_SIZE);
Review Comment:
warning: variable 'new_ptr' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
char* new_ptr = nullptr = (char*)malloc(bufferRef.size +
BUFFER_UNIT_SIZE);
```
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -239,6 +239,80 @@ Status DataTypeNumberSerDe<T>::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+template <typename T>
+Status DataTypeNumberSerDe<T>::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const ColumnType&>(column).get_data();
+
+ if constexpr (std::is_same_v<T, Int128>) {
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column data to
orc file.");
+ }
+ StringRef bufferRef;
+ bufferRef.data = ptr;
+ bufferRef.size = BUFFER_UNIT_SIZE;
+ size_t offset = 0;
+ const size_t begin_off = offset;
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 0) {
+ continue;
+ }
+ std::string value_str = fmt::format("{}", col_data[row_id]);
+ size_t len = value_str.size();
Review Comment:
warning: variable 'value_str' is not initialized
[cppcoreguidelines-init-variables]
be/src/vec/data_types/serde/data_type_number_serde.cpp:268:
```diff
- str = fmt::format("{}", col_data[row_id]);
+ str = 0 = fmt::format("{}", col_data[row_id]);
```
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -239,6 +239,80 @@ Status DataTypeNumberSerDe<T>::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+template <typename T>
+Status DataTypeNumberSerDe<T>::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const ColumnType&>(column).get_data();
+
+ if constexpr (std::is_same_v<T, Int128>) {
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
Review Comment:
warning: variable 'ptr' is not initialized [cppcoreguidelines-init-variables]
```suggestion
col_batch); = nullptr
```
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -137,5 +137,54 @@ Status
DataTypeDateTimeV2SerDe::write_column_to_mysql(const IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDateTimeV2SerDe::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch,
+ int start, int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const
ColumnVector<UInt64>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column data to orc
file.");
+ }
+ StringRef bufferRef;
+ bufferRef.data = ptr;
+ bufferRef.size = BUFFER_UNIT_SIZE;
+ size_t offset = 0;
+ const size_t begin_off = offset;
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 0) {
+ continue;
+ }
+
+ int len = binary_cast<UInt64,
DateV2Value<DateTimeV2ValueType>>(col_data[row_id])
+ .to_buffer(const_cast<char*>(bufferRef.data) +
offset, scale);
+ while (bufferRef.size - BUFFER_RESERVED_SIZE < offset + len) {
+ char* new_ptr = (char*)malloc(bufferRef.size + BUFFER_UNIT_SIZE);
Review Comment:
warning: variable 'new_ptr' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
char* new_ptr = nullptr = (char*)malloc(bufferRef.size +
BUFFER_UNIT_SIZE);
```
##########
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:
##########
@@ -142,5 +142,54 @@ Status DataTypeDateV2SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDateV2SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const
ColumnVector<UInt32>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
Review Comment:
warning: variable 'cur_batch' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
orc::StringVectorBatch* cur_batch = nullptr =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
```
##########
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:
##########
@@ -142,5 +142,54 @@ Status DataTypeDateV2SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeDateV2SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const
ColumnVector<UInt32>&>(column).get_data();
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
+ if (!ptr) {
+ return Status::InternalError(
+ "malloc memory error when write largeint column data to orc
file.");
+ }
+ StringRef bufferRef;
+ bufferRef.data = ptr;
+ bufferRef.size = BUFFER_UNIT_SIZE;
+ size_t offset = 0;
+ const size_t begin_off = offset;
+
+ for (size_t row_id = start; row_id < end; row_id++) {
+ if (cur_batch->notNull[row_id] == 0) {
+ continue;
+ }
+
+ int len = binary_cast<UInt32,
DateV2Value<DateV2ValueType>>(col_data[row_id])
+ .to_buffer(const_cast<char*>(bufferRef.data) +
offset);
+ while (bufferRef.size - BUFFER_RESERVED_SIZE < offset + len) {
+ char* new_ptr = (char*)malloc(bufferRef.size + BUFFER_UNIT_SIZE);
Review Comment:
warning: variable 'new_ptr' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
char* new_ptr = nullptr = (char*)malloc(bufferRef.size +
BUFFER_UNIT_SIZE);
```
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -239,6 +239,80 @@ Status DataTypeNumberSerDe<T>::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+template <typename T>
+Status DataTypeNumberSerDe<T>::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+ orc::ColumnVectorBatch*
orc_col_batch, int start,
+ int end,
+ std::vector<StringRef>&
buffer_list) const {
+ auto& col_data = assert_cast<const ColumnType&>(column).get_data();
+
+ if constexpr (std::is_same_v<T, Int128>) {
+ orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
+
+ char* ptr = (char*)malloc(BUFFER_UNIT_SIZE);
Review Comment:
warning: variable 'cur_batch' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
StringVectorBatch* cur_batch = nullptr =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
```
##########
be/src/vec/runtime/vfile_format_transformer.h:
##########
@@ -31,21 +34,26 @@ class VFileFormatTransformer {
VFileFormatTransformer(const VExprContextSPtrs& output_vexpr_ctxs, bool
output_object_data)
: _output_vexpr_ctxs(output_vexpr_ctxs),
_cur_written_rows(0),
- _output_object_data(output_object_data) {}
+ _output_object_data(output_object_data) {
+ DataTypes data_types;
Review Comment:
warning: variable 'data_types' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
DataTypes data_types = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
