github-actions[bot] commented on code in PR #24883:
URL: https://github.com/apache/doris/pull/24883#discussion_r1335825838
##########
be/src/vec/common/string_ref.h:
##########
@@ -235,6 +239,19 @@ struct StringRef {
bool end_with(char) const;
bool start_with(const StringRef& search_string) const;
bool end_with(const StringRef& search_string) const;
+ bool equals_ignore_case(const StringRef& other) const {
Review Comment:
warning: function 'equals_ignore_case' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool equals_ignore_case(const StringRef& other) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
