github-actions[bot] commented on code in PR #24721:
URL: https://github.com/apache/doris/pull/24721#discussion_r1336023957
##########
be/src/vec/runtime/vfile_format_transformer.h:
##########
@@ -31,7 +34,14 @@ class VFileFormatTransformer {
VFileFormatTransformer(const VExprContextSPtrs& output_vexpr_ctxs, bool
output_object_data)
: _output_vexpr_ctxs(output_vexpr_ctxs),
_cur_written_rows(0),
- _output_object_data(output_object_data) {}
+ _output_object_data(output_object_data) {
+ DataTypes data_types;
Review Comment:
warning: variable 'data_types' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
DataTypes data_types = 0;
```
##########
be/src/vec/runtime/vcsv_transformer.cpp:
##########
@@ -85,165 +89,33 @@ Status VCSVTransformer::close() {
}
Status VCSVTransformer::write(const Block& block) {
- using doris::operator<<;
+ auto ser_col = ColumnString::create();
+ ser_col->reserve(block.columns());
+ VectorBufferWriter buffer_writer(*ser_col.get());
Review Comment:
warning: variable 'buffer_writer' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
VectorBufferWriter buffer_writer = 0(*ser_col.get());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
