github-actions[bot] commented on code in PR #24896:
URL: https://github.com/apache/doris/pull/24896#discussion_r1336598266
##########
be/src/vec/functions/function_tokenize.cpp:
##########
@@ -29,46 +30,26 @@
#include "vec/common/string_ref.h"
#include "vec/core/block.h"
#include "vec/core/column_with_type_and_name.h"
-#include "vec/core/field.h"
#include "vec/data_types/data_type_nullable.h"
#include "vec/data_types/data_type_number.h"
-#include "vec/functions/simple_function_factory.h"
namespace doris::vectorized {
Status parse(const std::string& str, std::map<std::string, std::string>&
result) {
- std::string::size_type start = 0;
+ std::regex pattern(
+
R"delimiter((?:'([^']*)'|"([^"]*)"|([^,]*))\s*=\s*(?:'([^']*)'|"([^"]*)"|([^,]*)))delimiter");
+ std::smatch matches;
Review Comment:
warning: variable 'matches' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::smatch matches = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
