dataroaring commented on code in PR #23053:
URL: https://github.com/apache/doris/pull/23053#discussion_r1335173798
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -308,9 +311,25 @@ Status GroupCommitTable::_finish_group_commit_load(int64_t
db_id, int64_t table_
<< ", instance_id=" << print_id(instance_id)
<< ", executor status=" << status.to_string()
<< ", request commit status=" << st.to_string();
+ if (!prepare_failed) {
+ _exec_env->wal_mgr()->add_wal_path(_db_id, table_id, txn_id,
label);
+ std::string wal_path;
+ _exec_env->wal_mgr()->get_wal_path(txn_id, wal_path);
+ _exec_env->wal_mgr()->add_recover_wal(std::to_string(db_id),
std::to_string(table_id),
+ std::vector<std::string>
{wal_path});
Review Comment:
Do we need handle return value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
