github-actions[bot] commented on code in PR #24924: URL: https://github.com/apache/doris/pull/24924#discussion_r1337025721
########## be/src/pipeline/exec/file_scan_operator.h: ########## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <stdint.h> + +#include <string> + +#include "common/status.h" +#include "operator.h" +#include "pipeline/exec/scan_operator.h" +#include "pipeline/pipeline_x/operator.h" +#include "vec/exec/format/format_common.h" +#include "vec/exec/scan/vscan_node.h" + +namespace doris { +class ExecNode; +namespace vectorized { +class VFileScanner; +} // namespace vectorized +} // namespace doris + +namespace doris::pipeline { + +class FileScanOperatorX; +class FileScanLocalState final : public ScanLocalState<FileScanLocalState> { +public: + using Parent = FileScanOperatorX; + ENABLE_FACTORY_CREATOR(FileScanLocalState); + FileScanLocalState(RuntimeState* state, OperatorXBase* parent) + : ScanLocalState<FileScanLocalState>(state, parent) {} + + Status _init_scanners(std::list<vectorized::VScannerSPtr>* scanners) override; + void set_scan_ranges(const std::vector<TScanRangeParams>& scan_ranges) override { + _scan_ranges = scan_ranges; + } + int node_id() const { return _node_id; } Review Comment: warning: function 'node_id' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] int node_id() const { return _node_id; } ``` ########## be/src/pipeline/exec/scan_operator.h: ########## @@ -428,6 +432,7 @@ class ScanOperatorX : public OperatorX<LocalStateType> { TPushAggOp::type get_push_down_agg_type() { return _push_down_agg_type; } + int64_t get_push_down_count() const { return _push_down_count; } Review Comment: warning: function 'get_push_down_count' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] int64_t get_push_down_count() const { return _push_down_count; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
