EmmyMiao87 commented on a change in pull request #4932:
URL: https://github.com/apache/incubator-doris/pull/4932#discussion_r527514868
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InlineViewRef.java
##########
@@ -266,7 +266,9 @@ public TupleDescriptor createTupleDescriptor(Analyzer
analyzer) throws AnalysisE
}
columnSet.add(colAlias);
- columnList.add(new Column(colAlias,
selectItemExpr.getType().getPrimitiveType()));
+ // TODO: inlineView threat all column is nullable to make sure
query results are correct
+ // we should judge column whether is nullable by selectItemExpr in
the future
+ columnList.add(new Column(colAlias,
selectItemExpr.getType().getPrimitiveType(), true));
Review comment:
Unfortunately, we cannot directly obtain the information about whether
slot desc is nullable or not from Expr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
