yiguolei commented on code in PR #24978:
URL: https://github.com/apache/doris/pull/24978#discussion_r1349478525


##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -824,7 +825,8 @@ Status CsvReader::_prepare_parse(size_t* read_line, bool* 
is_parse_name) {
     io::FileReaderOptions reader_options =
             FileFactory::get_reader_options(_state, _file_description);
     if (_params.file_type == TFileType::FILE_STREAM) {
-        RETURN_IF_ERROR(FileFactory::create_pipe_reader(_params.load_id, 
&_file_reader, _state));

Review Comment:
   add comment here, to explain why set the parameter to true



##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -294,7 +294,8 @@ Status CsvReader::init_reader(bool is_load) {
     }
 
     if (_params.file_type == TFileType::FILE_STREAM) {
-        RETURN_IF_ERROR(FileFactory::create_pipe_reader(_range.load_id, 
&_file_reader, _state));

Review Comment:
   add comment here, to explain why set the parameter to false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to