weizuo93 commented on a change in pull request #4891:
URL: https://github.com/apache/incubator-doris/pull/4891#discussion_r530068677
##########
File path: be/src/olap/base_compaction.cpp
##########
@@ -43,9 +50,26 @@ OLAPStatus BaseCompaction::compact() {
RETURN_NOT_OK(pick_rowsets_to_compact());
TRACE("rowsets picked");
TRACE_COUNTER_INCREMENT("input_rowsets_count", _input_rowsets.size());
+ _tablet->set_clone_occurred(false);
+
+ return OLAP_SUCCESS;
+}
+
+OLAPStatus BaseCompaction::execute_compact() {
+ MutexLock lock(_tablet->get_base_lock(), TRY_LOCK);
+ if (!lock.own_lock()) {
+ LOG(WARNING) << "another base compaction is running. tablet=" <<
_tablet->full_name();
+ return OLAP_ERR_BE_TRY_BE_LOCK_ERROR;
+ }
+ TRACE("got base compaction lock");
+
+ if (_tablet->get_clone_occurred()) {
+ _tablet->set_clone_occurred(false);
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
