wangbo commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r536109020
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
##########
@@ -265,17 +265,16 @@ private void executeDynamicPartition() {
String tableName;
boolean skipAddPartition = false;
OlapTable olapTable;
- db.readLock();
+ olapTable = (OlapTable) db.getTable(tableId);
Review comment:
I get, you mean ```Performance is ahead of NPE```.
For the second point about ```lock sequence ```.
I think it should become programming specifications for Doris.
```
1 If try to lock multiple tables or dbs, it should use getXXXInOrderMethod.
2 If try to lock different type locks, lock sequence should be guaranteed.
3 The appearance of nested locks of the same type should be avoided.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
