yiguolei commented on code in PR #25489:
URL: https://github.com/apache/doris/pull/25489#discussion_r1360574791
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -1492,4 +1507,66 @@ void
FragmentMgr::_setup_shared_hashtable_for_broadcast_join(const TPipelineFrag
}
}
+Status FragmentMgr::create_and_get_task_scheduler(uint64_t wg_id, std::string
wg_name,
+ int cpu_hard_limit,
QueryContext* query_ctx_ptr) {
+ std::lock_guard<std::mutex> lock(_task_scheduler_lock);
Review Comment:
我觉得把Cgroup的task group 管理，单独独立出一个类来吧，别继续在fragment manger 里搞了，未来我们piplinex 和
非pipeline 要分离，感觉fragment manger里的map 太多了
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -1492,4 +1507,66 @@ void
FragmentMgr::_setup_shared_hashtable_for_broadcast_join(const TPipelineFrag
}
}
+Status FragmentMgr::create_and_get_task_scheduler(uint64_t wg_id, std::string
wg_name,
+ int cpu_hard_limit,
QueryContext* query_ctx_ptr) {
+ std::lock_guard<std::mutex> lock(_task_scheduler_lock);
Review Comment:
我觉得把Cgroup的task group 管理，单独独立出一个类来吧，别继续在fragment manger 里搞了，未来我们piplinex 和
非pipeline 要分离，感觉fragment manger里的map 太多了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
