gavinchou commented on code in PR #25579:
URL: https://github.com/apache/doris/pull/25579#discussion_r1363413379
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -247,39 +260,45 @@ Status Segment::load_pk_index_and_bf() {
return Status::OK();
}
Status Segment::load_index() {
- return _load_index_once.call([this] {
- if (_tablet_schema->keys_type() == UNIQUE_KEYS && _pk_index_meta !=
nullptr) {
- _pk_index_reader.reset(new PrimaryKeyIndexReader());
- RETURN_IF_ERROR(_pk_index_reader->parse_index(_file_reader,
*_pk_index_meta));
- _meta_mem_usage += _pk_index_reader->get_memory_size();
-
_segment_meta_mem_tracker->consume(_pk_index_reader->get_memory_size());
- return Status::OK();
- } else {
- // read and parse short key index page
- OlapReaderStatistics tmp_stats;
- PageReadOptions opts {
- .use_page_cache = true,
- .type = INDEX_PAGE,
- .file_reader = _file_reader.get(),
- .page_pointer = PagePointer(_sk_index_page),
- // short key index page uses NO_COMPRESSION for now
- .codec = nullptr,
- .stats = &tmp_stats,
- .io_ctx = io::IOContext {.is_index_data = true},
- };
- Slice body;
- PageFooterPB footer;
- RETURN_IF_ERROR(
- PageIO::read_and_decompress_page(opts, &_sk_index_handle,
&body, &footer));
- DCHECK_EQ(footer.type(), SHORT_KEY_PAGE);
- DCHECK(footer.has_short_key_page_footer());
-
- _meta_mem_usage += body.get_size();
- _segment_meta_mem_tracker->consume(body.get_size());
- _sk_index_decoder.reset(new ShortKeyIndexDecoder);
- return _sk_index_decoder->parse(body,
footer.short_key_page_footer());
- }
- });
+ auto status = [this]() {
+ return _load_index_once.call([this] {
+ if (_tablet_schema->keys_type() == UNIQUE_KEYS && _pk_index_meta
!= nullptr) {
+ _pk_index_reader.reset(new PrimaryKeyIndexReader());
+ RETURN_IF_ERROR(_pk_index_reader->parse_index(_file_reader,
*_pk_index_meta));
+ _meta_mem_usage += _pk_index_reader->get_memory_size();
+
_segment_meta_mem_tracker->consume(_pk_index_reader->get_memory_size());
+ return Status::OK();
+ } else {
+ // read and parse short key index page
+ OlapReaderStatistics tmp_stats;
+ PageReadOptions opts {
+ .use_page_cache = true,
+ .type = INDEX_PAGE,
+ .file_reader = _file_reader.get(),
+ .page_pointer = PagePointer(_sk_index_page),
+ // short key index page uses NO_COMPRESSION for now
+ .codec = nullptr,
+ .stats = &tmp_stats,
+ .io_ctx = io::IOContext {.is_index_data = true},
+ };
+ Slice body;
+ PageFooterPB footer;
+ RETURN_IF_ERROR(
+ PageIO::read_and_decompress_page(opts,
&_sk_index_handle, &body, &footer));
+ DCHECK_EQ(footer.type(), SHORT_KEY_PAGE);
+ DCHECK(footer.has_short_key_page_footer());
+
+ _meta_mem_usage += body.get_size();
+ _segment_meta_mem_tracker->consume(body.get_size());
+ _sk_index_decoder.reset(new ShortKeyIndexDecoder);
+ return _sk_index_decoder->parse(body,
footer.short_key_page_footer());
+ }
+ });
+ }();
+ if (!status.ok() && !config::disable_segment_cache) {
Review Comment:
Redundant check `!config::disable_segment_cache`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
