morningman commented on a change in pull request #5114:
URL: https://github.com/apache/incubator-doris/pull/5114#discussion_r547349233
##########
File path: be/src/exec/json_scanner.cpp
##########
@@ -487,10 +501,6 @@ void JsonReader::_set_tuple_value(rapidjson::Value&
objectValue, Tuple* tuple,
Status JsonReader::_handle_simple_json(Tuple* tuple, const
std::vector<SlotDescriptor*>& slot_descs,
MemPool* tuple_pool, bool* eof) {
// If you use a string as the key to find the json object, strlen will be
called every time, so the key is constructed in advance
Review comment:
This commend can be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
