github-actions[bot] commented on code in PR #24511:
URL: https://github.com/apache/doris/pull/24511#discussion_r1366831684
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -184,19 +224,20 @@ class InvertedIndexVisitor : public
lucene::util::bkd::bkd_reader::intersect_vis
uint32_t _num_hits;
bool _only_count;
lucene::util::bkd::bkd_reader* _reader;
- InvertedIndexQueryType _query_type;
+ PredicateType _low_op;
+ PredicateType _high_op;
public:
- std::string query_min;
- std::string query_max;
+ BinaryType query_min;
+ BinaryType query_max;
+ std::vector<BinaryType> query_points;
public:
- InvertedIndexVisitor(roaring::Roaring* hits, InvertedIndexQueryType
query_type,
+ InvertedIndexVisitor(roaring::Roaring* hits, InvertedIndexQueryBase*
range_query,
Review Comment:
warning: function
'std::doris::segment_v2::InvertedIndexVisitor::InvertedIndexVisitor' has a
definition with different parameter names
[readability-inconsistent-declaration-parameter-name]
```cpp
InvertedIndexVisitor(roaring::Roaring* hits, InvertedIndexQueryBase*
range_query,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:740:** the
definition seen here
```cpp
InvertedIndexVisitor::InvertedIndexVisitor(roaring::Roaring* h,
InvertedIndexQueryBase* query_value,
^
```
**be/src/olap/rowset/segment_v2/inverted_index_reader.h:235:** differing
parameters are named here: ('range_query'), in definition: ('query_value')
```cpp
InvertedIndexVisitor(roaring::Roaring* hits, InvertedIndexQueryBase*
range_query,
^
```
</details>
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -207,17 +248,18 @@ class InvertedIndexVisitor : public
lucene::util::bkd::bkd_reader::intersect_vis
void visit(lucene::util::bkd::bkd_docid_set_iterator* iter,
std::vector<uint8_t>& packed_value) override;
bool matches(uint8_t* packed_value);
+ bool _matches(const BinaryType& packed_value, const BinaryType& query_max,
Review Comment:
warning: function 'std::doris::segment_v2::InvertedIndexVisitor::_matches'
has a definition with different parameter names
[readability-inconsistent-declaration-parameter-name]
```cpp
bool _matches(const BinaryType& packed_value, const BinaryType&
query_max,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:768:** the
definition seen here
```cpp
bool InvertedIndexVisitor::_matches(const BinaryType& packed_value, const
BinaryType& qmax,
^
```
**be/src/olap/rowset/segment_v2/inverted_index_reader.h:250:** differing
parameters are named here: ('query_max', 'query_min'), in definition: ('qmax',
'qmin')
```cpp
bool _matches(const BinaryType& packed_value, const BinaryType&
query_max,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
