morningman commented on a change in pull request #5098:
URL: https://github.com/apache/incubator-doris/pull/5098#discussion_r548979294
##########
File path: .rat-excludes
##########
@@ -1,33 +0,0 @@
-.*json
Review comment:
Why delete this file?
##########
File path: be/src/util/bitmap_value.h
##########
@@ -1087,6 +1088,63 @@ class BitmapValue {
return *this;
}
+ // Compute the symmetric union between the current bitmap and the provided
bitmap.
+ // Possible type transitions are:
+ // SINGLE -> EMPTY
+ // BITMAP -> EMPTY
+ // BITMAP -> SINGLE
+ BitmapValue& operator^=(const BitmapValue& rhs) {
+ switch (rhs._type) {
+ case EMPTY:
+ break;
+ case SINGLE:
+ switch (_type) {
+ case EMPTY:
+ add(rhs._sv);
+ break;
+ case SINGLE:
+ if (_sv == rhs._sv) {
+ _type = EMPTY;
+ _bitmap.clear();
+ }else{
Review comment:
```suggestion
} else {
```
##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -477,6 +477,27 @@ StringVal BitmapFunctions::bitmap_and(FunctionContext*
ctx, const StringVal& lhs
return serialize(ctx, &bitmap);
}
+StringVal BitmapFunctions::bitmap_xor(FunctionContext* ctx, const StringVal&
lhs,
Review comment:
```suggestion
StringVal BitmapFunctions::bitmap_xor(FunctionContext* ctx, const StringVal&
lhs,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
