This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 5cb5121cf6e [coverage](pipeline) Remove unless code and add call
method for coverage (#25552)
5cb5121cf6e is described below
commit 5cb5121cf6e95409ca0ce483e108f0846082c192
Author: HappenLee <[email protected]>
AuthorDate: Mon Oct 23 15:52:43 2023 +0800
[coverage](pipeline) Remove unless code and add call method for coverage
(#25552)
Remove unless code and add call method for coverage
---
be/src/pipeline/exec/exchange_sink_operator.h | 2 --
be/src/pipeline/exec/multi_cast_data_stream_sink.h | 2 +-
be/src/util/proto_util.h | 4 +---
be/src/vec/sink/vdata_stream_sender.cpp | 2 +-
4 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/be/src/pipeline/exec/exchange_sink_operator.h
b/be/src/pipeline/exec/exchange_sink_operator.h
index 9575df01a2a..ed8df4dbe01 100644
--- a/be/src/pipeline/exec/exchange_sink_operator.h
+++ b/be/src/pipeline/exec/exchange_sink_operator.h
@@ -57,8 +57,6 @@ public:
Status close(RuntimeState* state) override;
- RuntimeState* state() { return _state; }
-
private:
std::unique_ptr<ExchangeSinkBuffer<vectorized::VDataStreamSender>>
_sink_buffer;
int _dest_node_id = -1;
diff --git a/be/src/pipeline/exec/multi_cast_data_stream_sink.h
b/be/src/pipeline/exec/multi_cast_data_stream_sink.h
index dc96506d665..c0e4edd3e30 100644
--- a/be/src/pipeline/exec/multi_cast_data_stream_sink.h
+++ b/be/src/pipeline/exec/multi_cast_data_stream_sink.h
@@ -38,7 +38,7 @@ public:
MultiCastDataStreamSinkOperator(OperatorBuilderBase* operator_builder,
DataSink* sink)
: DataSinkOperator(operator_builder, sink) {}
- bool can_write() override { return true; }
+ bool can_write() override { return _sink->can_write(); }
};
class MultiCastDataStreamSinkOperatorX;
diff --git a/be/src/util/proto_util.h b/be/src/util/proto_util.h
index b11180ab290..2b8b524da54 100644
--- a/be/src/util/proto_util.h
+++ b/be/src/util/proto_util.h
@@ -45,9 +45,7 @@ Status request_embed_attachment_contain_block(Params*
brpc_request, Closure* clo
return st;
}
-inline bool enable_http_send_block(
- const PTransmitDataParams& request,
- bool transfer_large_data_by_brpc =
config::transfer_large_data_by_brpc) {
+inline bool enable_http_send_block(const PTransmitDataParams& request) {
if (!config::transfer_large_data_by_brpc) {
return false;
}
diff --git a/be/src/vec/sink/vdata_stream_sender.cpp
b/be/src/vec/sink/vdata_stream_sender.cpp
index 3bce57eda98..4f9816db0b4 100644
--- a/be/src/vec/sink/vdata_stream_sender.cpp
+++ b/be/src/vec/sink/vdata_stream_sender.cpp
@@ -207,7 +207,7 @@ Status Channel<Parent>::send_remote_block(PBlock* block,
bool eos, Status exec_s
{
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(ExecEnv::GetInstance()->orphan_mem_tracker());
- if (enable_http_send_block(_brpc_request,
config::transfer_large_data_by_brpc)) {
+ if (enable_http_send_block(_brpc_request)) {
RETURN_IF_ERROR(transmit_block_http(_state->exec_env(), _closure,
_brpc_request,
_brpc_dest_addr));
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
